Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Materials and binary parsing #1

Merged
merged 5 commits into from Jun 18, 2013
Merged

Materials and binary parsing #1

merged 5 commits into from Jun 18, 2013

Conversation

smike
Copy link
Contributor

@smike smike commented Mar 31, 2013

Hi,
Thanks so much for writing this library! It's come in really useful for me, but I needed to extend it a bit and hopefully the changes can be useful to other as well.

I've added the beginnings of parsing materials. For now I'm just getting colors but I might add more in the future.

I also started using a different library to parse binary data. I ran into bugs with BinaryParser where it didn't mask the typed data properly, so sometimes I would get a word with data in bits higher than 16. Also, jDataView tries to use native DataView objects if the browser supports them so I think it should be a bit faster.

BTW, shameless plug, but you can try my chrome extension to make looking at the diffs a bit easier. https://chrome.google.com/webstore/detail/side-by-side-diff-view-in/ihmhmdmhllhleioijdeoocgoddjckbcd or https://github.com/smike/diffhub

Thanks again!
--smike

@smike
Copy link
Contributor Author

smike commented Jun 16, 2013

ping?

@timknip
Copy link
Owner

timknip commented Jun 16, 2013

Pong ;-) Away from home at the moment... I'll get back to you tomorrow.

@smike
Copy link
Contributor Author

smike commented Jun 17, 2013

Thank you an no worries. I was just afraid the original email got lost in your inbox. I know it happens to me all the time.

timknip added a commit that referenced this pull request Jun 18, 2013
Materials and binary parsing
@timknip timknip merged commit a1e5bcb into timknip:master Jun 18, 2013
@smike
Copy link
Contributor Author

smike commented Jun 20, 2013

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants