Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thanks so much for writing this library! It's come in really useful for me, but I needed to extend it a bit and hopefully the changes can be useful to other as well.
I've added the beginnings of parsing materials. For now I'm just getting colors but I might add more in the future.
I also started using a different library to parse binary data. I ran into bugs with BinaryParser where it didn't mask the typed data properly, so sometimes I would get a word with data in bits higher than 16. Also, jDataView tries to use native DataView objects if the browser supports them so I think it should be a bit faster.
BTW, shameless plug, but you can try my chrome extension to make looking at the diffs a bit easier. https://chrome.google.com/webstore/detail/side-by-side-diff-view-in/ihmhmdmhllhleioijdeoocgoddjckbcd or https://github.com/smike/diffhub
Thanks again!
--smike