Accessibility improvement: match aria-label to tag text for "read more" links #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @timlrx on Vercel. @timlrx first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks for the patch. Agree to leave the color decisions to the users - I just rotate it every major version for a fresh coat of paint. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when performing a Lighthouse analysis of the demo deployment of this template, the accessibility (a11y) score is 92 for both mobile and desktop with the following warnings:
Having the
aria-labelin the "Read More" link element of the post list item more closely match the tag's text ("Read more") increases the accessibility score to 96 for both mobile and desktop.The color contrast warning can be fixed with different primary/secondary colors in the Tailwind configuration, but I think changing that should be up to @timlrx and/or individual users of the template.