Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update comments component incase of no provider #843

Merged
merged 2 commits into from Apr 4, 2024

Conversation

talhatahir
Copy link
Contributor

Incase if someone does not have any commenting platform enabled, the code will still show the Load Comments button.
This PR fixes it and only shows the Load Comments button if a commenting platform is provided.

Copy link

vercel bot commented Feb 3, 2024

Someone is attempting to deploy a commit to a Personal Account owned by @timlrx on Vercel.

@timlrx first needs to authorize it.

Copy link

vercel bot commented Feb 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tailwind-nextjs-starter-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 1:49pm

@talhatahir
Copy link
Contributor Author

@timlrx please be so kind to have a look at this PR.

@timlrx
Copy link
Owner

timlrx commented Mar 31, 2024

There's an error in the deployed build:

Error: 
  x An object member cannot be declared optional
    ,-[/vercel/path0/components/Comments.tsx:11:1]

Could you fix it and ensure that it builds without error?

@talhatahir
Copy link
Contributor Author

@timlrx Fixed it! Thanks ✌️

@talhatahir
Copy link
Contributor Author

@timlrx can you have a look

@timlrx
Copy link
Owner

timlrx commented Apr 4, 2024

Thanks for the fix!

@timlrx timlrx merged commit f88e368 into timlrx:main Apr 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants