fixes #35 #52
Merged
fixes #35 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduction of portfolioService that is injected into the strategy. It is via the portfolioService that the strategy can query the positions and transactions. The portfolio manager updates the positions and transaction by subscribing to each transaction.
remove logging
Moved portfolio methods to protected and implemented portfolio service that is injected into the strategy as the interface to access the postions, value and balances of a strategy. Fill was updated to not set the time as this was causing issues with replay and rolling the epruntime to the current date.
removed excessive logging
|
Hi Tim, Autoformatting was turned off so a few white spaces. Happy to autoformat and re push |
timolson
added a commit
that referenced
this pull request
Aug 4, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.