Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations needed #93

Closed
timoxley opened this issue Apr 23, 2015 · 3 comments
Closed

Translations needed #93

timoxley opened this issue Apr 23, 2015 · 3 comments

Comments

@timoxley
Copy link
Owner

Some recent changes need translations, I did some google translating but can you have a look at the commits below please @tdd?

timoxley added a commit that referenced this issue Apr 23, 2015
timoxley added a commit that referenced this issue Apr 23, 2015
timoxley added a commit that referenced this issue Apr 23, 2015
@timoxley
Copy link
Owner Author

Also how can we get the translation API happening in the wrapper files so it's not all inline?

@tdd
Copy link
Collaborator

tdd commented Apr 23, 2015

Hey @timoxley! Just pushed a quick set of FR L10n tweaks. Beware of Google translate 😉

The wrapper system here is specific to your repo, not what we usually go with for workshopper. I'll have to dive into this deeper in the future to try and find a clean way to do this right from the infra. workshopper-wrappedexec is something different still (mostly used to hook into various API method calls so we can trace them and assert they're used / not used).

I don't see an easy way to let wrappers, which are plain Node programs, access workshopper's i18n layer right now (which is far more complex than it seems at first glance). I agree inline translation stinks, with its duplicated wrapper files, but that's as good as we can get just now 😞

@timoxley
Copy link
Owner Author

Just pushed a quick set of FR L10n tweaks

Thank you! 💃

Beware of Google translate 😉

Yeah I knew it was going to be crappy, but perhaps better than nothing until you got a chance to rework it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants