Skip to content

Commit

Permalink
added assertion for the email field.
Browse files Browse the repository at this point in the history
  • Loading branch information
rashmivkulkarni committed Sep 4, 2018
1 parent c76d13e commit af2ede4
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions x-pack/test/functional/apps/security/users.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ export default function ({ getService, getPageObjects }) {
log.debug('actualUsers = %j', users);
expect(users.Lee.roles).to.eql(['kibana_user']);
expect(users.Lee.fullname).to.eql('LeeFirst LeeLast');
expect(users.Lee.email).to.eql('lee@myEmail.com');
expect(users.Lee.reserved).to.be(false);
});

Expand Down
4 changes: 3 additions & 1 deletion x-pack/test/functional/page_objects/security_page.js
Original file line number Diff line number Diff line change
Expand Up @@ -175,12 +175,14 @@ export function SecurityPageProvider({ getService, getPageObjects }) {
return mapAsync(users, async user => {
const fullnameElement = await user.findByCssSelector('[data-test-subj="userRowFullName"]');
const usernameElement = await user.findByCssSelector('[data-test-subj="userRowUserName"]');
const emailElement = await user.findByCssSelector('[data-header="Email Address"]');
const rolesElement = await user.findByCssSelector('[data-test-subj="userRowRoles"]');
const isReservedElementVisible = await user.findByCssSelector('td:last-child');

return {
username: await usernameElement.getVisibleText(),
fullname: await fullnameElement.getVisibleText(),
email: await emailElement.getVisibleText(),
roles: (await rolesElement.getVisibleText()).split(',').map(role => role.trim()),
reserved: (await isReservedElementVisible.getProperty('innerHTML')).includes('reservedUser')
};
Expand Down Expand Up @@ -216,7 +218,7 @@ export function SecurityPageProvider({ getService, getPageObjects }) {
await testSubjects.setValue('passwordInput', userObj.password);
await testSubjects.setValue('passwordConfirmationInput', userObj.confirmPassword);
await testSubjects.setValue('userFormFullNameInput', userObj.fullname);
await testSubjects.setValue('userFormEmailInput', 'example@example.com');
await testSubjects.setValue('userFormEmailInput', userObj.email);
log.debug('Add roles: ', userObj.roles);
const rolesToAdd = userObj.roles || [];
for (let i = 0; i < rolesToAdd.length; i++) {
Expand Down

0 comments on commit af2ede4

Please sign in to comment.