Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image generators are failing #20

Closed
misterhee opened this issue May 15, 2014 · 6 comments
Closed

Image generators are failing #20

misterhee opened this issue May 15, 2014 · 6 comments

Comments

@misterhee
Copy link

Trying to use any of the image generators throws a js error.

e.g.

5/15/14 2:36:54.567 PM Sketch[7238]: Script error on line 180 (Female): TypeError: 'null' is not an object (evaluating 'imagesFileNames. count')

5/15/14 2:36:54.568 PM Sketch[7238]: Exception: {
line = 188;
stack = "loadImages\nmain\nloadImages\nglobal code";
}

(FYI - Using Sketch 3.02)

@timuric
Copy link
Owner

timuric commented May 15, 2014

@misterhee Are you using the latest version of the plugin? When did you downloaded it?

@misterhee
Copy link
Author

Downloaded 0.1.3 (.zip) from the releases page ~ 30 min ago.

On Thu, May 15, 2014 at 2:52 PM, Timur Carpeev notifications@github.comwrote:

@misterhee https://github.com/misterhee Are you using the latest
version of the plugin? When did you downloaded it?


Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-43269782
.

@timuric
Copy link
Owner

timuric commented May 15, 2014

@misterhee can you please try to rename folder to "generator"?

@misterhee
Copy link
Author

That did the trick!

Funny, I had already renamed the folder (as I didn't like seeing the long
"Content-generator-sketch-plugin-0.1.3" name in the menu), but I hadn't
restarted Sketch yet.

I guess 2 things should be changed to unsure this doesn't happen to other
new users:

  1. Ensure the required "generator" folder is inside the release .zip/tar
  2. update the instructions text slightly to make note that the plugin
    folder has to be called "generator"

FYI - Case did not seem to matter - I renamed to "Generator" and it still
worked.

Great work BTW - Love time saving utils for boring/repetitive tasks...

On Thu, May 15, 2014 at 2:57 PM, Timur Carpeev notifications@github.comwrote:

@misterhee https://github.com/misterhee can you please try to rename
folder to "generator"?


Reply to this email directly or view it on GitHubhttps://github.com//issues/20#issuecomment-43270235
.

@timuric
Copy link
Owner

timuric commented May 15, 2014

@misterhee Thanks for the report. Actually name can be anything else, I just need to update regex, apparently it fails when parsing a name with dots or dashes. Will fix it in the next release :)

@timuric timuric closed this as completed May 15, 2014
@misterhee
Copy link
Author

Broken again after 3.03?

I get a error such as:

6/25/14 6:33:49.867 PM Female (Sketch Plugin)[439]: ReferenceError: Can't find variable: scriptPath.
Plugin “Female”, line 168.
» var pluginFolder = scriptPath.match(/Plugins/([\w -])*/)[0] + "/"; «

(same error for any of the other photos)

6/25/14 5:51:57.836 PM Nature and urban (Sketch Plugin)[439]: ReferenceError: Can't find variable: scriptPath.
Plugin “Nature and urban”, line 168.
» var pluginFolder = scriptPath.match(/Plugins/([\w -])*/)[0] + "/"; «

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants