Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.py assert on config.private.json keys #48

Closed
luke-john opened this issue Dec 13, 2013 · 2 comments
Closed

config.py assert on config.private.json keys #48

luke-john opened this issue Dec 13, 2013 · 2 comments
Labels

Comments

@luke-john
Copy link
Contributor

There is currently an assert on config.py https://github.com/timvideos/streaming-system/blob/master/config.py#L64 which is throwing the Makefile when you try and serve.

Given that config.json is intended to hold default/testing values and not real data, I think removing this assert makes sense.

@mithro
Copy link
Member

mithro commented Dec 13, 2013

Yes, makes sense.

BTW Would you mind moving all the pycon stuff into a config.private.json.example ?

@luke-john
Copy link
Contributor Author

Sure, I've added a separate pull request #50 with this file added.

@mithro mithro closed this as completed Feb 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants