New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add {{git_creation_date_localized}} #50
Add {{git_creation_date_localized}} #50
Conversation
I created a fresh The error suggests it probably has to do with this line: |
I fixed the tests and added a new one to test creation dates. |
Really nice work! Thanks for the PR! My only doubt is if we can remove Plan to release this later this week! |
I was going through the existing code base and cleaning things up a bit. The trick of using commit_timestamp = git.log(
realpath, date="short", format="%at", diff_filter="A"
) |
OK, I opened squidfunk/mkdocs-material#2551 to discuss adding native support for the creation date in the material theme. |
The reason I didn't enable
Yes, see https://git-scm.com/docs/git-diff#Documentation/git-diff.txt---diff-filterACDMRTUXB82308203 |
Yes, it's the right decision. My doubt was 1) what is you only want to have the creation date, and not the last updated? and 2) what we if add more git date related fields. It's a fine solution for now. FYI, I also opened this PR for native mkdocs-material support: squidfunk/mkdocs-material#2579 |
relating issue: #49
This pr adds
{{git_creation_date_localized}}
I improved performance of getting the creation date by using
git.log(realpath, date="short", format="%at", diff_filter="A")
. The reverse option mentioned in the issue doesn't work because it reverse the output after limiting the lines.