chore: close db if node initialized check fails (ChainSafe#1551)

timwu20 · May 4, 2021 · d7b87f1 · d7b87f1
1 parent b86c7ff
commit d7b87f1
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/dot/node.go b/dot/node.go
@@ -153,6 +153,14 @@ func NodeInitialized(basepath string, expected bool) bool {
 		return false
 	}
 
+	defer func() {
+		// close database
+		err = db.Close()
+		if err != nil {
+			logger.Error("failed to close database", "error", err)
+		}
+	}()
+
 	// load genesis data from initialised node database
 	_, err = state.NewBaseState(db).LoadGenesisData()
 	if err != nil {
@@ -164,12 +172,6 @@ func NodeInitialized(basepath string, expected bool) bool {
 		return false
 	}
 
-	// close database
-	err = db.Close()
-	if err != nil {
-		logger.Error("failed to close database", "error", err)
-	}
-
 	return true
 }