This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 93
refactor(markdown in json): replace PagesJsonBlockMarkdown with gatsby-plugin-json-remark #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hql query to use *Html fields.
…nd add *Html placeholder fields to dummy.json.
…ummy.json. upgrade gatsby-plugin-json-remark to 1.1.0. merge upstream changes.
Thanks @mirabilio! Much appreciated. I'll take a look & test this ASAP. |
Hey @mirabilio, finally got a chance to test; looks good! This is a significant improvement. I knew there had to be a better way. |
This was referenced May 29, 2020
Closed
parthsdoshi
reviewed
Oct 18, 2020
Comment on lines
+6665
to
+6669
<<<<<<< HEAD | ||
|
||
======= | ||
|
||
>>>>>>> upstream/master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't seem right
parthsdoshi
reviewed
Oct 18, 2020
Comment on lines
+14699
to
+14703
<<<<<<< HEAD | ||
|
||
======= | ||
|
||
>>>>>>> upstream/master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this too
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gatsby-plugin-json-remark
plugin with configuration:paths: [`${__dirname}/content/pages`],
pathsExclude: [`${__dirname}/content/pages/contact.json`],
fieldNameBlacklist: ['id', 'children', 'parent', 'fields', 'internal', 'path', 'template'],
gatsby-node.js
childrenPagesJsonBlockMarkdown
block from graphql query inpage.js
titleHtml
,hero.headlineHtml
,hero.textLineHtml
,hero.ctas.labelHtml
,blocks.contentHtml
to graphql query inpage.js
dummy.json
.vscode/
and*.code-workspace
to.gitignore