Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

refactor(markdown in json): replace PagesJsonBlockMarkdown with gatsby-plugin-json-remark #41

Merged
merged 10 commits into from
May 13, 2020

Conversation

mirabilio
Copy link
Contributor

  • install gatsby-plugin-json-remark plugin with configuration:
    • paths: [`${__dirname}/content/pages`],
      pathsExclude: [`${__dirname}/content/pages/contact.json`],
      fieldNameBlacklist: ['id', 'children', 'parent', 'fields', 'internal', 'path', 'template'],
  • remove onCreateNode function from gatsby-node.js
  • remove childrenPagesJsonBlockMarkdown block from graphql query in page.js
  • add fields titleHtml, hero.headlineHtml, hero.textLineHtml, hero.ctas.labelHtml, blocks.contentHtml to graphql query in page.js
  • add *Html placeholder fields to dummy.json
  • add .vscode/ and *.code-workspace to .gitignore

@spbyrne
Copy link
Contributor

spbyrne commented Apr 29, 2020

Thanks @mirabilio! Much appreciated. I'll take a look & test this ASAP.

@spbyrne
Copy link
Contributor

spbyrne commented May 13, 2020

Hey @mirabilio, finally got a chance to test; looks good! This is a significant improvement. I knew there had to be a better way.

Comment on lines +6665 to +6669
<<<<<<< HEAD

=======

>>>>>>> upstream/master

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't seem right

Comment on lines +14699 to +14703
<<<<<<< HEAD

=======

>>>>>>> upstream/master

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this too

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants