New branching workflow #3953
New branching workflow #3953
Conversation
ENG-921 Prompt user to create branch when making a change
Similar to our Hackathon POC, if users have opted into "editorial workflow", upon clicking "save", if the user is on the default branch, we should intercept the action and prompt them to create a new branch. Wireframes (WIP): Tina Git Workflow Wireframing - Saving To Locked Branch.png
For reference, here's the POC: |
🦋 Changeset detectedLatest commit: d6149d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/@tinacms/toolkit/src/packages/form-builder/FormBuilder.tsx
Outdated
Show resolved
Hide resolved
| } | ||
| }, [currentBranch]) | ||
|
|
||
| const handleCreateBranch = React.useCallback((value) => { |
There was a problem hiding this comment.
The prefix here doesn't actually get applied to the branch, testing it out with input "hello", just creates a branch named "hello" instead of "tina/hello"
Note that this does work as expected when prompted after saving
There was a problem hiding this comment.
@jeffsee55 Good catch, should be an easy fix.
|
After you delete a branch, from the collection list page: (e.g /admin/index.html#/collections/post/~). This correct modal flashes for a second: but then is replaced by the more ambiguous modal: |
|
When you kickstart the editorial workflow through creating a document, it lands you back on the empty create-document page, (even though the document has been created): |
|
"Create Branch" workflow from the branch modal doesn't work, we talked about removing that for now: |
Demo: https://www.loom.com/share/9f4f36a264e24be8a9d1c7b2008a1255
Fixes ENG-921
TODO: