LPS-120376 Create single sql for other team to import #2012
Conversation
**:information_source: This is safe to backport to 7.3.x.** These are just maintenance updates to reflect the migration of the `liferay-amd-loader` project to the named scope (ie. `@liferay/amd-loader`) version of the package. There should be no behavioral changes, but this bring the project into a namespace that we fully control. There are some cascading side-effects of this, which mean that we have to additionally update `@liferay/npm-bundler-preset-liferay-dev` (because it references the loader), which in turn means we must update `@liferay/npm-scripts` (because it references the preset). Finally, we have to update `@liferay/npm-bundler` because it references the loader too. Release notes for all of these: - https://github.com/liferay/liferay-frontend-projects/releases/tag/amd-loader%2Fv4.3.1 - https://github.com/liferay/liferay-frontend-projects/releases/tag/npm-bundler-preset-liferay-dev%2Fv4.6.5 - https://github.com/liferay/liferay-frontend-projects/releases/tag/npm-scripts%2Fv33.1.4 - https://github.com/liferay/liferay-frontend-projects/releases/tag/npm-bundler%2Fv3.0.1
This reverts commit fbd81d6.
This reverts commit c6af102.
…om SampleSQLBuilder output
…ld-common.xml as we never take advantage of it
…ple.sql.properties.file" so that same properties are used by ant script and SampleSQLBuilder
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
ci:test:sf |
|
ci:test:relevant |
liferay-continuous-integration
added
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-120376-pr-1778 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#4282 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#7202 |
| @@ -3,7 +3,24 @@ | |||
| <project basedir="." default="run" name="benchmarks"> | |||
| <import file="../build-common.xml" /> | |||
|
|
|||
| <target name="build-sample-sql"> | |||
| <property name="sample-data-sql" value="sample-data-${sample.sql.db.type}.sql" /> | |||
There was a problem hiding this comment.
@slnn
There is no "sample-data-${sample.sql.db.type}.sql" in https://github.com/liferay/liferay-portal/tree/master/benchmarks. It is confusing you have this property setting here.
I guess you need this for our benchmark project, but this is not a good reason to put it here.
Tina.
There was a problem hiding this comment.
@slnn Sorry, I misunderstood you. This is not for property reading, it is for output, right?
| /> | ||
| </delete> | ||
| </target> | ||
|
|
||
| <target depends="clean, build-sample-sql" name="merge-sql"> |
There was a problem hiding this comment.
@slnn Who is going to use this "merge-sql"?
If I want to run sample sql builder to get a sample sql file to import into my database, what should I do?
|
Just run this ant merge-sql
Tina Tian <notifications@github.com> 于 2020年10月22日周四 12:25写道：
… ***@***.**** commented on this pull request.
------------------------------
In benchmarks/build.xml
<#2012 (comment)>
:
> />
</delete>
</target>
+
+ <target depends="clean, build-sample-sql" name="merge-sql">
@slnn <https://github.com/slnn> Who is going to use this "merge-sql"?
If I want to run sample sql builder to get a sample sql file to import
into my database, what should I do?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2012 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJBKJ23RL3TWSLO7BZYAF3SL6X4FANCNFSM4SZLBBKQ>
.
|
|
@dantewang I just had a talk with Lily, the goal is I run a command and got an sql which can be imported into my database, then I start portal with that database, everything works fine. Let's work on that first, then we go back to this. Tina. |
|
Hi @tinatian Update for the previous issues I mentioned: 2>For the encoding issue on Windows, double check it with QA and more Windows users, the origin issue caused by the way that QA import data So I resend it in: Lily |
No description provided.