[Clean] Removed await keyword where not required "The rewarder" test
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `attach` here returns a `Contract` instance, not a promise, so, there is no need to use `await`.
zzzuhaibmohd
added a commit
to zzzuhaibmohd/damn-vulnerable-defi-solutions
that referenced
this pull request
Jul 28, 2022
zzzuhaibmohd
added a commit
to zzzuhaibmohd/damn-vulnerable-defi-solutions
that referenced
this pull request
Jul 28, 2022
|
Thanks, should be solved in v3 following your suggestion! |
soyccan
added a commit
to soyccan/damn-vulnerable-defi
that referenced
this pull request
Aug 12, 2023
- Upgradable contract - Checks-effects-interactions violation
soyccan
added a commit
to soyccan/damn-vulnerable-defi
that referenced
this pull request
Aug 12, 2023
- Upgradable contract - Checks-effects-interactions violation
soyccan
added a commit
to soyccan/damn-vulnerable-defi
that referenced
this pull request
Aug 12, 2023
- Upgradable contract - Checks-effects-interactions violation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
attachhere returns aContractinstance, not a promise, so, there is no need to useawait.