Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Failed conversion of HTTPS proxy link #450

Closed
2 tasks done
richardzone opened this issue Jan 29, 2022 · 2 comments
Closed
2 tasks done

[BUG] Failed conversion of HTTPS proxy link #450

richardzone opened this issue Jan 29, 2022 · 2 comments

Comments

@richardzone
Copy link

richardzone commented Jan 29, 2022

确认版本最新

  • 我已经确认在最新Action编译的版本中复现

检索issue

  • 我已经确认之前没有issue涉及此BUG

subconverter版本

Commit 2f78eaf

转换过程

HTTPS Proxy convert to Clash/Surge/Etc

转换设置

tg://http?server=1.2.3.4&port=233&user=user&pass=pass&remarks=Example&group=xxx
https://t.me/http?server=1.2.3.4&port=233&user=user&pass=pass&remarks=Example&group=xxx

Above doesn't work for HTTPS proxies (like caddy-forwardproxy or this)

I have tried the following, none of them works:

tg://https?server=1.2.3.4&port=233&user=user&pass=pass&remarks=Example&group=xxx
tg://http?type=https&server=1.2.3.4&port=233&user=user&pass=pass&remarks=Example&group=xxx
tg://http?tls=true&server=1.2.3.4&port=233&user=user&pass=pass&remarks=Example&group=xxx
https://t.me/https?server=1.2.3.4&port=233&user=user&pass=pass&remarks=Example&group=xxx

复现步骤

Trying to use HTTPS proxy:

tg://https?server=1.2.3.4&port=233&user=user&pass=pass&remarks=Example&group=xxx
tg://http?type=https&server=1.2.3.4&port=233&user=user&pass=pass&remarks=Example&group=xxx
tg://http?tls=true&server=1.2.3.4&port=233&user=user&pass=pass&remarks=Example&group=xxx
https://t.me/https?server=1.2.3.4&port=233&user=user&pass=pass&remarks=Example&group=xxx

期望结果

Be able to use HTTPS proxy

实际结果

  - {name: Example, server: 1.2.3.4, port: 233, type: http, username: user, password: pass, tls: false, skip-cert-verify: false, udp: true}

You can see type: http and tls: false

错误信息

No response

tindy2013 added a commit that referenced this issue Feb 9, 2022
Fix matching not-range does not work (#428).
Fix parsing and generating of HTTPS nodes (#450).
Add servername field for Clash VMess nodes (#449 #451).
Add VMess AEAD option for Surge and Quantumult X configs.
@richardzone
Copy link
Author

@tindy2013 I see the issue is fixed in latest commit - thank you for awesome work and happy tiger year!

@richardzone
Copy link
Author

Can confirm this is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant