Expose artefact version tag in TOML build file #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tindzk
force-pushed
the
feat/resolve-full-deps
branch
from
965a0fc
to
9609b4f
Compare
Currently, the version tag for dependencies in the TOML file always encodes the platform name and binary Scala version. Internally, Seed already has to handle different version tags. Expose this functionality in `scalaDep` by introducing a fourth parameter. The detailed changes for this are: - `Build`: Introduce `VersionTag` which was previously called `PlatformSuffix` and located in `Artefact` - `Build`: Make `Dep` a sealed trait with two children, `JavaDep` and `ScalaDep`, the only difference between those two being that `ScalaDep` has a `VersionTag` parameter. The version tag defaults to `PlatformBinary` in order to retain compatibility. - `TomlUtils`: Introduce codec for parsing `VersionTag` values - `Artefact`: Remove `Versioned` in favour of `Dep` - `Artefact`: Provide function for `Dep` → `Artefact` conversions - `ArtefactResolution`: Refactor functions for collecting dependencies
The .gitignore rule `test/` should not match `src/test/`. Resolve this by restricting the rule only to `test` in the root directory. Also, remove redundant `project/target/` rule.
tindzk
force-pushed
the
feat/resolve-full-deps
branch
from
9609b4f
to
da1e333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the version tag for dependencies in the TOML file always
encodes the platform name and binary Scala version. Internally,
Seed already has to handle different version tags. Expose this
functionality in
scalaDepby introducing a fourth parameter. Thedetailed changes for this are:
Build: IntroduceVersionTagwhich was previously calledPlatformSuffixand located inArtefactBuild: MakeDepa sealed trait with two children,JavaDepandScalaDep, the only difference between those two being thatScalaDephas aVersionTagparameter. The version tag defaultsto
PlatformBinaryin order to retain compatibility.TomlUtils: Introduce codec for parsingVersionTagvaluesArtefact: RemoveVersionedin favour ofDepArtefact: Provide function forDep→ArtefactconversionsArtefactResolution: Refactor functions for collectingdependencies