Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update common-interfaces.ts #33

Closed
wants to merge 2 commits into from
Closed

Conversation

nicoraffin
Copy link

See issue #11.
Optional interface elements are blocking TypeScript compilation, string or undefined is not assignable to string index type string.

See issue tinesoft#11.
Optional interface elements are blocking TypeScript compilation, string or undefined is not assignable to string index type string.
@ghost
Copy link

ghost commented Dec 21, 2018

There were the following issues with this Pull Request

  • Commit: 8eec281
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@tinesoft
Copy link
Owner

FYI, you could have simply reopened PR #31 and edited both description and commit, to avoid duplicating the issue...

Ok, now at least we have a clear context, and the changes you made are more coherent with the issue. 😄
To take it even further, you can even completely delete the line:

 [key: string]: 'deny' | 'allow' | 'dismiss';

(i dont recall any valid reason why it was there in the first place...)

Once done, please update you commit message to follow the Angular git:

fix(typings): fix lint isssue due to bad typings in NgcCookieConsentStatus interface

Please git --amend and git push --force the commit instead of making a new one

Thanks in advance

This line could be removed because values are already listed below

Co-Authored-By: nicoraffin <39700670+nicoraffin@users.noreply.github.com>
@ghost
Copy link

ghost commented Jan 3, 2019

There were the following issues with this Pull Request

  • Commit: 8eec281
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: d7adfe4
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@sylvainonweb
Copy link

So, is there a chance this pull request to be merged ?

@tinesoft tinesoft closed this Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants