ci: ensure plugin requirements get installed in CI (kedro-org#208)

* ci: install the plugin alongside test requirements * ci: install the plugin alongside test requirements * Update kedro-airflow.yml * Update kedro-datasets.yml * Update kedro-docker.yml * Update kedro-telemetry.yml * Update kedro-airflow.yml * Update kedro-datasets.yml * Update kedro-airflow.yml * Update kedro-docker.yml * Update kedro-telemetry.yml * ci(telemetry): update isort config to correct sort * Don't use profile ¯\_(ツ)_/¯ Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> * chore(datasets): remove empty `tool.black` section * chore(docker): remove empty `tool.black` section --------- Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu> Signed-off-by: Tom Kurian <tom_kurian@mckinsey.com>
tingtingQB · May 30, 2023 · 373e166 · 373e166
1 parent 9381816
commit 373e166
Show file tree

Hide file tree

Showing 9 changed files with 43 additions and 34 deletions.
diff --git a/.circleci/continue_config.yml b/.circleci/continue_config.yml
@@ -69,8 +69,7 @@ commands:
           command: |
             cd <<parameters.plugin>>
             pip install git+https://github.com/kedro-org/kedro@main
-            pip install .
-            pip install -r test_requirements.txt
+            pip install . -r test_requirements.txt  # TODO(deepyaman): Define `test` extra and `pip install .[test]`
       - run:
           name: Install pre-commit hooks
           command: |
@@ -177,7 +176,7 @@ commands:
           command: conda activate kedro_plugins; pip install git+https://github.com/kedro-org/kedro@main
       - run:
           name: Install all requirements
-          command: conda activate kedro_plugins; cd <<parameters.plugin>>; pip install -r test_requirements.txt -U
+          command: conda activate kedro_plugins; cd <<parameters.plugin>>; pip install . -r test_requirements.txt  # TODO(deepyaman): Define `test` extra and `pip install .[test]`
       - run:
           name: Pip freeze
           command: conda activate kedro_plugins; pip freeze
@@ -323,7 +322,7 @@ jobs:
       - run:
           name: Maybe trigger the release workflow
           command: |
-            conda activate kedro_plugins;
+            conda activate kedro_plugins
             pip install requests
             ./tools/circleci/circleci_release.py
 

diff --git a/.github/workflows/check-plugin.yml b/.github/workflows/check-plugin.yml
@@ -42,7 +42,7 @@ jobs:
       - name: Install dependencies
         run: |
           cd ${{ inputs.plugin }}
-          pip install -r test_requirements.txt
+          pip install . -r test_requirements.txt  # TODO(deepyaman): Define `test` extra and `pip install .[test]`
       - name: pip freeze
         run: pip freeze
       - name: Run unit tests for Linux / all plugins
@@ -84,7 +84,7 @@ jobs:
         run: |
             cd ${{ inputs.plugin }}
             pip install git+https://github.com/kedro-org/kedro@main
-            pip install -r test_requirements.txt
+            pip install . -r test_requirements.txt  # TODO(deepyaman): Define `test` extra and `pip install .[test]`
             pip freeze
       - name: Install pre-commit hooks
         run: |
@@ -121,7 +121,7 @@ jobs:
         run: |
           cd ${{ inputs.plugin }}
           pip install git+https://github.com/kedro-org/kedro@main
-          pip install -r test_requirements.txt
+          pip install . -r test_requirements.txt  # TODO(deepyaman): Define `test` extra and `pip install .[test]`
       - name: pip freeze
         run: pip freeze
       - name: Run end to end tests

diff --git a/.github/workflows/kedro-airflow.yml b/.github/workflows/kedro-airflow.yml
@@ -1,12 +1,16 @@
-name: Run checks on kedro-airflow
+name: Run checks on Kedro-Airflow
 
 on:
   push:
-    paths:
-      - "kedro-airflow/**"
+    paths-ignore:
+       - "kedro-datasets/**"
+       - "kedro-docker/**"
+       - "kedro-telemetry/**"
   pull_request:
-    paths:
-      - "kedro-airflow/**"
+    paths-ignore:
+       - "kedro-datasets/**"
+       - "kedro-docker/**"
+       - "kedro-telemetry/**"
     types: [ synchronize ]
 
 jobs:

diff --git a/.github/workflows/kedro-datasets.yml b/.github/workflows/kedro-datasets.yml
@@ -1,12 +1,16 @@
-name: Run checks on kedro-datasets
+name: Run checks on Kedro-Datasets
 
 on:
   push:
-    paths:
-      - "kedro-datasets/**"
+    paths-ignore:
+       - "kedro-airflow/**"
+       - "kedro-docker/**"
+       - "kedro-telemetry/**"
   pull_request:
-    paths:
-      - "kedro-datasets/**"
+    paths-ignore:
+       - "kedro-airflow/**"
+       - "kedro-docker/**"
+       - "kedro-telemetry/**"
     types: [ synchronize ]
 
 jobs:

diff --git a/.github/workflows/kedro-docker.yml b/.github/workflows/kedro-docker.yml
@@ -1,12 +1,16 @@
-name: Run checks on kedro-docker
+name: Run checks on Kedro-Docker
 
 on:
   push:
-    paths:
-      - "kedro-docker/**"
+    paths-ignore:
+       - "kedro-airflow/**"
+       - "kedro-datasets/**"
+       - "kedro-telemetry/**"
   pull_request:
-    paths:
-      - "kedro-docker/**"
+    paths-ignore:
+       - "kedro-airflow/**"
+       - "kedro-datasets/**"
+       - "kedro-telemetry/**"
     types: [ synchronize ]
 
 jobs:

diff --git a/.github/workflows/kedro-telemetry.yml b/.github/workflows/kedro-telemetry.yml
@@ -1,12 +1,16 @@
-name: Run checks on kedro-telemetry
+name: Run checks on Kedro-Telemetry
 
 on:
   push:
-    paths:
-      - "kedro-telemetry/**"
+    paths-ignore:
+       - "kedro-airflow/**"
+       - "kedro-datasets/**"
+       - "kedro-docker/**"
   pull_request:
-    paths:
-      - "kedro-telemetry/**"
+    paths-ignore:
+       - "kedro-airflow/**"
+       - "kedro-datasets/**"
+       - "kedro-docker/**"
     types: [ synchronize ]
 
 jobs:

diff --git a/kedro-datasets/pyproject.toml b/kedro-datasets/pyproject.toml
@@ -27,8 +27,6 @@ include = ["kedro_datasets*"]
 readme = {file = "README.md", content-type = "text/markdown"}
 version = {attr = "kedro_datasets.__version__"}
 
-[tool.black]
-
 [tool.isort]
 profile = "black"
 

diff --git a/kedro-docker/pyproject.toml b/kedro-docker/pyproject.toml
@@ -53,8 +53,6 @@ addopts = """
     --no-cov-on-fail
     -ra"""
 
-[tool.black]
-
 [tool.isort]
 multi_line_output = 3
 include_trailing_comma = true

diff --git a/kedro-telemetry/pyproject.toml b/kedro-telemetry/pyproject.toml
@@ -42,6 +42,4 @@ include_trailing_comma = true
 force_grid_wrap = 0
 use_parentheses = true
 line_length = 88
-known_third_party = "kedro"
-
-[tool.black]
+known_first_party = "kedro_telemetry"