Allow persistentStorage - opens up multinode #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClashTheBunny
force-pushed
the
persistent-storage
branch
from
c7f1880
to
3d97446
Compare
fixes tinkerbell#42 for me Signed-off-by: Randall Mason <Randall@Mason.CH>
ClashTheBunny
force-pushed
the
persistent-storage
branch
from
3d97446
to
5a9b9b7
Compare
| @@ -18,6 +18,8 @@ stack: | |||
| port: 8080 | |||
| image: alpine | |||
| downloadsDest: /opt/hook | |||
| persistentStorage: true | |||
There was a problem hiding this comment.
mind if we make this opt-in and default to false here?
| - ReadWriteMany | ||
| resources: | ||
| requests: | ||
| storage: 50Gi |
There was a problem hiding this comment.
This needs to be customizable and can probably be a much smaller default given HookOS isn't more than a <1Gi.
| @@ -18,6 +18,8 @@ stack: | |||
| port: 8080 | |||
| image: alpine | |||
| downloadsDest: /opt/hook | |||
| persistentStorage: true | |||
| storageClass: ceph-filesystem | |||
There was a problem hiding this comment.
I think we want this to be specified by the user and not default. We can add a check to one of the templates that verifies if persistentStorage == true then require storageClass.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An example of what I did to fix #42, it works great for me!
It's also needed to be added to image downloading (https://github.com/tinkerbell/sandbox/blob/4195ea1c46f7ea9e70f297be190a81ed00ba2ec9/deploy/stack/helm/manifests/ubuntu-download.yaml) like I did here: https://github.com/ClashTheBunny/tink-settings/blob/main/tink-system/templates/download.yaml
Why is this needed
Multiple nodes
Fixes: #
How Has This Been Tested?
Works for me!
How are existing users impacted? What migration steps/scripts do we need?
The default should be not to have any change, but I'm including the overridden value to show where it would need to change.
Checklist:
I have: