Install tools instead of relying on go run
#241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdoherty4
force-pushed
the
feature/tools.go
branch
2 times, most recently
from
623371b
to
4180d86
Compare
Codecov Report
@@ Coverage Diff @@
## main #241 +/- ##
=======================================
Coverage 76.21% 76.21%
=======================================
Files 17 17
Lines 412 412
=======================================
Hits 314 314
Misses 87 87
Partials 11 11 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chrisdoherty4
force-pushed
the
feature/tools.go
branch
2 times, most recently
from
dacf33f
to
54888da
Compare
|
|
chrisdoherty4
force-pushed
the
feature/tools.go
branch
2 times, most recently
from
58d7bc0
to
20ef31b
Compare
chrisdoherty4
changed the title
go run
chrisdoherty4
force-pushed
the
feature/tools.go
branch
from
20ef31b
to
74ff1e5
Compare
chrisdoherty4
force-pushed
the
feature/tools.go
branch
3 times, most recently
from
d076039
to
d311dbc
Compare
chrisdoherty4
commented
Mar 19, 2023
chrisdoherty4
force-pushed
the
feature/tools.go
branch
from
d311dbc
to
be90275
Compare
chrisdoherty4
changed the title
go rungo run
chrisdoherty4
force-pushed
the
feature/tools.go
branch
2 times, most recently
from
3d996e9
to
81464a6
Compare
go run has proven sluggish when invoking Make recipes. This change trends us toward an install and use approach skipping the compilation invoked with go run. Signed-off-by: Chris Doherty <chris.doherty4@gmail.com>
chrisdoherty4
force-pushed
the
feature/tools.go
branch
from
81464a6
to
afc9083
Compare
jacobweinstock
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go running tools is slow as Go recompiles the program with ever invocation. This PR changes to installing tools into$PWD/out/toolsready to be used by the rest of theMakefileimproving the dependent recipe's performance.