Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include a version file in Hook #176

Closed
jacobweinstock opened this issue Aug 9, 2023 · 0 comments · Fixed by #177
Closed

include a version file in Hook #176

jacobweinstock opened this issue Aug 9, 2023 · 0 comments · Fixed by #177

Comments

@jacobweinstock
Copy link
Member

It would be nice to be able to cat a file while hook is running to know what version it is. helpful for debugging issues from users.

Expected Behaviour

Current Behaviour

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

  • Operating System and version (e.g. Linux, Windows, MacOS):

  • How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:

  • Link to your project or a code example to reproduce issue:
@jacobweinstock jacobweinstock mentioned this issue Aug 13, 2023
Merged
3 tasks
@mergify mergify bot closed this as completed in #177 Aug 16, 2023
mergify bot added a commit that referenced this issue Aug 16, 2023
@mergify
Add os-release file (#177)
1c438a9 
## Description


This allows us to know at runtime the version of HookOS. Also, modified the prompt to contain the version so that when sharing screenshots to debug it will be clear the Hook version.

Turned down the kernel.printk log level to warning (4) so that the console Getty doesn't get messy with kernel messages. Better UX (hopefully). A side effect of this is that we won't see messages anymore on the console when workflow action containers run. Syslog messages will still be sent to Boots.

<img width="732" alt="image" src="https://github.com/tinkerbell/hook/assets/12081036/074764f3-b211-4c34-91f2-6d27511be212">


## Why is this needed



Fixes: #176 

## How Has This Been Tested?





## How are existing users impacted? What migration steps/scripts do we need?





## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [ ] added unit or e2e tests
- [ ] provided instructions on how to upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add os-release file jacobweinstock/hook
1 participant
@jacobweinstock