Enable skipping of network in setup.sh #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
approved these changes
Jun 16, 2021
micahhausler
added a commit
to micahhausler/tinkerbell-docs
that referenced
this pull request
Jun 25, 2021
Signed-off-by: Micah Hausler <mhausler@amazon.com>
3 tasks
|
@micahhausler looks like just a minor linting complaint - if [[ -z "$TINKERBELL_SKIP_NETWORKING" ]]; then
+ if [[ -z $TINKERBELL_SKIP_NETWORKING ]]; then |
* Fixed path to deploy dir in log message * Allow TINKERBELL_CIDR and TINKERBELL_HOST_IP to be overridable * Set environment variables for tink cli in .env Signed-off-by: Micah Hausler <mhausler@amazon.com>
Fixed |
micahhausler
added a commit
to micahhausler/tinkerbell-docs
that referenced
this pull request
Jun 25, 2021
Signed-off-by: Micah Hausler <mhausler@amazon.com>
jacobweinstock
added a commit
to tinkerbell/tinkerbell-docs
that referenced
this pull request
Jun 25, 2021
3 tasks
This was referenced Jul 19, 2021
mmlb
pushed a commit
to tinkerbell/tinkerbell-docs
that referenced
this pull request
Aug 4, 2021
Signed-off-by: Micah Hausler <mhausler@amazon.com>
HoKim98
pushed a commit
to HoKim98/sandbox
that referenced
this pull request
Aug 27, 2021
Enable skipping of network in setup.sh Signed-off-by: Ho Kim <great.ho.kim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
setup.shTINKERBELL_CIDRandTINKERBELL_HOST_IPto be overridableWhy is this needed
.envfile after its generated and just setTINKERBELL_CIDRandTINKERBELL_HOST_IPbefore runninggenerate-env.shFixes: #87
How Has This Been Tested?
Ran changes locally
How are existing users impacted? What migration steps/scripts do we need?
N/A
Checklist:
I'll update the bare metal docs in a follow up PR calling out the escape hatch