Use init with registry since it forks #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids many zombie processes left over Signed-off-by: Steve Wills <steve@mouf.net>
swills
force-pushed
the
registry-init
branch
from
0385f1a
to
e8977c3
Compare
mmlb
approved these changes
Nov 20, 2021
mergify bot
added a commit
that referenced
this pull request
Dec 16, 2021
Prevents accidental resource exhaustion Signed-off-by: Steve Wills <steve@mouf.net> ## Description While looking at the issue in #115 I decided to add resource limits to avoid future accidental resource exhaustion. Not strictly required and perhaps the limits themselves can use tweaking, but it seems useful to add a safety. ## Why is this needed See description Fixes: # ## How Has This Been Tested? In VM ## How are existing users impacted? What migration steps/scripts do we need? Avoids potential issue ## Checklist: I have: - [N/A] updated the documentation and/or roadmap (if required) - [N/A] added unit or e2e tests - [N/A] provided instructions on how to upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids many zombie processes left over
Description
Without this change, many zombie processes get left over in the registry container. Eventually these will run the system out of PIDs
Why is this needed
System will have issues if too many zombie processes are left over
Fixes: #
How Has This Been Tested?
Monitored number of processes via
docker statsHow are existing users impacted? What migration steps/scripts do we need?
Bug fix
Checklist:
I have: