hasActiveWorkflow should consider workflows in state PENDING and RUNNING #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splaspood
force-pushed
the
hasActiveWorkflow-0
branch
from
2f093c8
to
6edbfb2
Compare
splaspood
force-pushed
the
hasActiveWorkflow-0
branch
from
29ac24c
to
007a6f7
Compare
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
=======================================
Coverage 40.90% 40.90%
=======================================
Files 40 40
Lines 2056 2056
=======================================
Hits 841 841
Misses 1130 1130
Partials 85 85
Continue to review full report at Codecov.
|
kqdeng
suggested changes
Jan 5, 2021
splaspood
force-pushed
the
hasActiveWorkflow-0
branch
from
007a6f7
to
9fb00dd
Compare
kqdeng
previously approved these changes
Jan 5, 2021
Cbkhare
previously requested changes
Jan 6, 2021
Signed-off-by: James W. Brinkerhoff <jwb@paravolve.net>
Signed-off-by: James W. Brinkerhoff <jwb@paravolve.net>
splaspood
force-pushed
the
hasActiveWorkflow-0
branch
from
9fb00dd
to
f701c42
Compare
mmlb
dismissed
Cbkhare’s stale review
Always booting to osie&tink-worker if a workflow is already started is ok.
|
@mmlb / @splaspood I have opened a bug with reference to this commit #125. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When checking for the status of a 'job' boots currently only considers PENDING workflows. This change makes it consider RUNNING workflows to be 'active' as well.
Why is this needed
During workflow execution we pass status updates back to our central API by way of boots. As-is, the hasActiveWorkflow function will reject those status updates as it only considers 'PENDING' workflows to be active.