Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform tweaks #124

Merged
merged 9 commits into from
Jun 1, 2020
Merged

Terraform tweaks #124

merged 9 commits into from
Jun 1, 2020

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented May 20, 2020

No description provided.

@gauravgahlot gauravgahlot added the area/setup Issue related to tinkerbell setup label May 21, 2020
@gauravgahlot gauravgahlot added this to In Progress in Issues List via automation May 21, 2020
@mmlb mmlb requested review from gauravgahlot, parauliya and nathangoulding and removed request for gauravgahlot and parauliya May 21, 2020 21:05
parauliya
parauliya previously approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@parauliya parauliya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parauliya
Copy link
Contributor

Please rebase your branch before merging it.

@mmlb
Copy link
Contributor Author

mmlb commented May 27, 2020

Helps with #105

mmlb added 9 commits May 28, 2020 15:32
@mmlb
Add nix-shell and direnv goodness
7724b55
@mmlb
deploy/tf: add newlines at EOF
0707266
@mmlb
deploy/tf: Remove bogus defaults for token and project id
61f338c 
Don't really like have invalid values in the .tf files, especially when
Hashicorp has extensive documentation for setting variables.
@mmlb
deploy/tf: Specify packet provider version range
bfdef18 
To avoid incompatible version bumps.
@mmlb
deploy/tf: Replace local.project_id -> var.project_id
96711e5 
There is no reason to shadow project_id with a local variable.
@mmlb
deploy/tf: Rename packet devices to more useful names
b28914c 
s/tf-/tink-/ because this makes more sense especially if using a project
that has other servers.
@mmlb
deploy/tf: Make facility variable
6f3e841 
For availability or even latency/locality.
@mmlb
deploy/tf: Add a device_type variable
2b6a679 
c3.small.x86s are in high demand atm and other devices are just as
usable.
@mmlb
deploy/tf: Add provisioner_dns_name output
5e23f9c 
This is a dns entry packet adds for all provisioned devices and makes
it easier to reach the services running on the provisioner.
@mmlb
Copy link
Contributor Author

mmlb commented May 28, 2020

@parauliya rebased

@mmlb mmlb requested a review from parauliya May 28, 2020 19:32
parauliya
parauliya approved these changes Jun 1, 2020
View reviewed changes
Copy link
Contributor

@parauliya parauliya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parauliya parauliya merged commit 0b076b4 into tinkerbell:master Jun 1, 2020
Issues List automation moved this from In Progress to Just shipped Jun 1, 2020
@mmlb mmlb deleted the terraform-tweaks branch June 1, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parauliya parauliya parauliya approved these changes

@gauravgahlot gauravgahlot Awaiting requested review from gauravgahlot

@nathangoulding nathangoulding Awaiting requested review from nathangoulding

Assignees

@mmlb mmlb

Labels
area/setup Issue related to tinkerbell setup
Projects
No open projects
Issues List
  
Just shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmlb @parauliya @gauravgahlot