Fixed gofmt and golint issues and added the check in CI #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmlb
suggested changes
May 21, 2020
There was a problem hiding this comment.
Running goimports -w . I get:
~/go/src/github.com/tinkerbell/tink> git diff | e:cat
diff --git a/protos/hardware/hardware.pb.go b/protos/hardware/hardware.pb.go
index da25773..4f4b60e 100644
--- a/protos/hardware/hardware.pb.go
+++ b/protos/hardware/hardware.pb.go
@@ -6,11 +6,12 @@ package hardware
import (
context "context"
fmt "fmt"
+ math "math"
+
proto "github.com/golang/protobuf/proto"
grpc "google.golang.org/grpc"
codes "google.golang.org/grpc/codes"
status "google.golang.org/grpc/status"
- math "math"
)
// Reference imports to suppress errors if they are not otherwise used.
diff --git a/protos/template/template.pb.go b/protos/template/template.pb.go
index f793cb9..89a863c 100644
--- a/protos/template/template.pb.go
+++ b/protos/template/template.pb.go
@@ -6,12 +6,13 @@ package template
import (
context "context"
fmt "fmt"
+ math "math"
+
proto "github.com/golang/protobuf/proto"
timestamp "github.com/golang/protobuf/ptypes/timestamp"
grpc "google.golang.org/grpc"
codes "google.golang.org/grpc/codes"
status "google.golang.org/grpc/status"
- math "math"
)
// Reference imports to suppress errors if they are not otherwise used.
diff --git a/protos/workflow/workflow.pb.go b/protos/workflow/workflow.pb.go
index ec89a58..b5db11a 100644
--- a/protos/workflow/workflow.pb.go
+++ b/protos/workflow/workflow.pb.go
@@ -6,12 +6,13 @@ package workflow
import (
context "context"
fmt "fmt"
+ math "math"
+
proto "github.com/golang/protobuf/proto"
timestamp "github.com/golang/protobuf/ptypes/timestamp"
grpc "google.golang.org/grpc"
codes "google.golang.org/grpc/codes"
status "google.golang.org/grpc/status"
- math "math"
)
|
Also lets use |
parauliya
force-pushed
the
fix_fmt_lint_issue
branch
from
ae3b6ca
to
3f5d4b9
Compare
gauravgahlot
force-pushed
the
fix_fmt_lint_issue
branch
from
3f5d4b9
to
b960c15
Compare
parauliya
force-pushed
the
fix_fmt_lint_issue
branch
5 times, most recently
from
0793ccf
to
69ab901
Compare
|
@parauliya can you rebase instead of merge master in please? merge makes history messier. |
|
Besides that :lgtm: |
parauliya
force-pushed
the
fix_fmt_lint_issue
branch
from
b0a237d
to
d0638bb
Compare
@mmlb , I rebased my branch to upstream/master. |
This commit has the following things 1. Fixed the goimports and golint issue in the current code. 2. Add check for goimports and golint issues in the CI pipeline
parauliya
force-pushed
the
fix_fmt_lint_issue
branch
from
d0638bb
to
8baa560
Compare
parauliya
changed the title
mmlb
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the following things
1. Fixed the goimports and golint issue in the current code.
2. Add check for goimports and golint issues in the CI pipeline