Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 'delete' command in 'tink hardware' cli #149

Merged
merged 1 commit into from
Jun 11, 2020
Merged

Added 'delete' command in 'tink hardware' cli #149

merged 1 commit into from
Jun 11, 2020

Conversation

parauliya
Copy link
Contributor

@parauliya parauliya commented Jun 4, 2020 •
edited

Now tink hardware cli will have delete command which works based on hardware-id as follows:

tink hardware delete <hardware-id>

This will enable the functionality of deleting a hardware.

@parauliya parauliya force-pushed the fix_109 branch 2 times, most recently from 6b4afb6 to 5f6521f Compare June 4, 2020 15:11
@parauliya parauliya self-assigned this Jun 4, 2020
@parauliya parauliya added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 4, 2020
@parauliya parauliya linked an issue Jun 4, 2020 that may be closed by this pull request
tink hardware doesn't have delete action #109
Closed
@parauliya parauliya added this to In Progress in Issues List via automation Jun 4, 2020
gauravgahlot
gauravgahlot suggested changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@gauravgahlot gauravgahlot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

cmd/tink-cli/cmd/hardware/delete.go Outdated Show resolved Hide resolved
cmd/tink-cli/cmd/hardware/delete.go Show resolved Hide resolved
protos/hardware/hardware.proto Outdated Show resolved Hide resolved
cmd/tink-cli/cmd/hardware/delete.go Outdated Show resolved Hide resolved
gauravgahlot
gauravgahlot approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@gauravgahlot gauravgahlot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauravgahlot gauravgahlot added the ready-to-merge Signal to Mergify to merge the PR. label Jun 11, 2020
@mergify mergify bot merged commit 637af08 into tinkerbell:master Jun 11, 2020
Issues List automation moved this from In Progress to Just shipped Jun 11, 2020
@gauravgahlot gauravgahlot deleted the fix_109 branch June 11, 2020 08:13
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravgahlot gauravgahlot gauravgahlot approved these changes

Assignees

@parauliya parauliya

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
No open projects
Issues List
  
Just shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tink hardware doesn't have delete action
3 participants
@parauliya @gauravgahlot @mmlb