Revert "Try out setting strict_method: rebase"
#159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b2d1b4c. Might revist after some further experimentation/exploration with Mergify. The way we have GitHub setup to dismiss reviews on pushes automatically makes the dev experience almost as bad as if there was no mergify at all. Mergify will happily rebase a PR but GitHub will block merging. It would be nice to try out letting Mergify manage the "dismiss reviews on code pushes" bit and see if it's smart enough to not dismiss when it's doing it normal job.
grahamc
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b2d1b4c.
Might revist after some further experimentation/exploration with
Mergify. The way we have GitHub setup to dismiss reviews on pushes
automatically makes the dev experience almost as bad as if there was no
mergify at all. Mergify will happily rebase a PR but GitHub will block
merging. It would be nice to try out letting Mergify manage the "dismiss
reviews on code pushes" bit and see if it's smart enough to not dismiss
when it's doing it normal job.