Fixed Issue 80: Modified the test framework for tink repo #177
Conversation
parauliya
force-pushed
the
fix_80
branch
13 times, most recently
from
828ab8c
to
0bebf03
Compare
parauliya
force-pushed
the
fix_80
branch
8 times, most recently
from
9378a71
to
b453857
Compare
This framework was written a while ago but is commented and there have been a lot of changes since then. 1. Remove the target concepts completely 2. Changed the way of writting templates 3. Changed the way of creating workflows 4. Generating certs are not the part of docker-compose anymore TODO: This framework works well for single worker. There are few changes required in the framework to make it work for multiple workers
There was a problem hiding this comment.
I would like to help you to move this PR forward, I think it is valuable but it needs documentation (in the code itself). As a developer, I need to open https://pkg.go.dev/github.com/tinkerbell/tink@v0.0.0-20200714130438-0100e535bd94/test/framework?tab=doc and I need to be able to figure out how and when to use this framework quickly.
|
This conversation with @mmlb happened in the public Tinkerbell channel, so I am reporting it here for visibility @mrmrcoleman . From my understanding, we can move from drone to something else that matches our needs (docker), probably GitHub Action that is free for OSS project or Travis. (I vote for actions).
|
|
btw I moved this to blocked because I think we have to change CI provider first |
|
We can always have 2 CI for the time being. |
|
@parauliya can you modify this issue in order to run as GitHub action? I think @mmlb is right and we can have a e2e pipeline that runs on its own. ideally, it will be nice to have one label based on this one #224 . if you can prepare a single command that runs the e2e tests I can help you hook it up as Gh action. |
|
We are moving to #277 , this should not be required anymore |
This framework was written a while ago but is commented and there have been a lot of changes since then.
TODO:
This framework works well for single worker. There are few changes required in the framework to make it work for multiple workers