Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated json example in docs to new structure #191

Merged
merged 3 commits into from
Jul 6, 2020
Merged

updated json example in docs to new structure #191

merged 3 commits into from
Jul 6, 2020

Conversation

kqdeng
Copy link
Contributor

@kqdeng kqdeng commented Jun 24, 2020 •
edited

  • updated all the examples that used the old data model

@kqdeng kqdeng changed the title updated json example to new structure updated json example in docs to new structure Jun 24, 2020
@kqdeng kqdeng force-pushed the update-hello-world-example branch 2 times, most recently from 9d505d2 to c7be845 Compare June 25, 2020 14:59
@kqdeng kqdeng force-pushed the update-hello-world-example branch from c7be845 to 6fcbe7e Compare June 25, 2020 15:00
gauravgahlot
gauravgahlot approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@gauravgahlot gauravgahlot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauravgahlot gauravgahlot added the kind/documentation Categorizes issue or PR as related to documentation. label Jul 6, 2020
@gauravgahlot gauravgahlot added this to In Progress in Issues List via automation Jul 6, 2020
@gauravgahlot gauravgahlot added the ready-to-merge Signal to Mergify to merge the PR. label Jul 6, 2020
@kqdeng kqdeng merged commit 8ade723 into tinkerbell:master Jul 6, 2020
Issues List automation moved this from In Progress to Just shipped Jul 6, 2020
@kqdeng kqdeng deleted the update-hello-world-example branch July 6, 2020 13:49
@kqdeng kqdeng restored the update-hello-world-example branch July 6, 2020 19:43
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravgahlot gauravgahlot gauravgahlot approved these changes

@parauliya parauliya Awaiting requested review from parauliya

@mrmrcoleman mrmrcoleman Awaiting requested review from mrmrcoleman

Assignees

@kqdeng kqdeng

Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
No open projects
Issues List
  
Just shipped
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kqdeng @gauravgahlot @mmlb