Fix issue #204: Added validation to avoid duplication of mac addresses in the hardware database #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parauliya
added
the
kind/feature
parauliya
force-pushed
the
fix_204
branch
3 times, most recently
from
c08333e
to
fa8b8c8
Compare
parauliya
force-pushed
the
fix_204
branch
2 times, most recently
from
bf72baf
to
ab9d4d1
Compare
…c addresses in the hardware database
gauravgahlot
suggested changes
Jul 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If someone tries to push the hardware data which contains a mac address which is already present in the database, the API will fail with the error explaining that "this mac address is already present in the database.
Why is this needed
Fixes: #204
How Has This Been Tested?
I have tried to push the hardware data with different id but same mac address which is already present in the database and it did't allow me to push the hardware data by saying that that particular mac address is present in the database
How are existing users impacted? What migration steps/scripts do we need?
The exising user will not be able to push the hardware data which contains the mac address which is already present in the database.
No Migration steps/scripts needed.