Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: gitignore files generated during vagrant provisioning #220

Merged
merged 1 commit into from
Jul 17, 2020
Merged

chore: gitignore files generated during vagrant provisioning #220

merged 1 commit into from
Jul 17, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Jul 17, 2020 •
edited

Description

There are two files generated by the setup.sh script that are annoying
during a vagrant provisioning because there are not ignored by git:

  • envrc is the file we use to make setup.sh idempotent and
    configurable. It gets generated first time and reused during
    setup.sh.

  • deploy/state contains files such as certs or cache files that are
    relevant for your current provisioning.

Why is this needed

It helps to avoid the mistake of pushing useless files.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

chore: gitignore files generated during vagrant provisioning
acabbf2 
There are two files generated by the `setup.sh` script that are annoying
during a vagrant provisioning because there are not ignored by git:

* `envrc` is the file we use to make `setup.sh` idempotent and
  configurable. It gets generated first time and reused during
  `setup.sh`.

* `deploy/state` contains files such as certs or cache files that are
  relevant for your current provisioning.
@gianarb gianarb added area/setup Issue related to tinkerbell setup size/XS estimate of the amount of work to address the issue priority/backlog Higher priority than priority/awaiting-more-evidence. labels Jul 17, 2020
gauravgahlot
gauravgahlot approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@gauravgahlot gauravgahlot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauravgahlot gauravgahlot added the ready-to-merge Signal to Mergify to merge the PR. label Jul 17, 2020
@mergify mergify bot merged commit 71f3ac3 into tinkerbell:master Jul 17, 2020
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravgahlot gauravgahlot gauravgahlot approved these changes

Assignees
No one assigned
Labels
area/setup Issue related to tinkerbell setup priority/backlog Higher priority than priority/awaiting-more-evidence. size/XS estimate of the amount of work to address the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gianarb @gauravgahlot @mmlb