Disable tk client setup if an --help flag is present #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An up and running Tinkerbell Server should not be a requirement for the `help` command to work. This is a bit tricky because our client is globally instantiated as part of the root command. I made it to work for: ``` $ ./cmd/tink-cli/tink-cli workflow --help ``` Previously the command returned `2020/06/08 11:16:25 undefined TINKERBELL_CERT_URL`. Now it returns the help command. I think this should work the same way, but it is hard to do, so I am skipping it for now. ``` $ ./cmd/tink-cli/tink-cli workflow ``` Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An up and running Tinkerbell Server should not be a requirement for the
helpcommand to work.This is a bit tricky because our client is globally instantiated as part
of the root command.
I made it to work for:
Previously the command returned
2020/06/08 11:16:25 undefined TINKERBELL_CERT_URL. Now it returns the help command.Why is this needed
Fixed #164
How Has This Been Tested?
Run command:
How are existing users impacted? What migration steps/scripts do we need?
They will get as output the helper of the command and not an error.