Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make golint-ci happy #239

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Make golint-ci happy #239

merged 1 commit into from
Aug 6, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Aug 6, 2020

We will use golint-ci with staticcheck and some other useful analysis.

This PR makes golint-ci happy

gauravgahlot
gauravgahlot previously approved these changes Aug 6, 2020
Copy link
Contributor

@gauravgahlot gauravgahlot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way to go.

thebsdbox
thebsdbox previously approved these changes Aug 6, 2020
Copy link
Contributor

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of good code cleanup here

@gauravgahlot
Copy link
Contributor

@gianarb you have conflicts now. 😄

We will use golint-ci with staticcheck and some other useful analysis.

This PR makes golint-ci happy

Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
@gauravgahlot gauravgahlot added the ready-to-merge Signal to Mergify to merge the PR. label Aug 6, 2020
@gianarb gianarb removed the request for review from thebsdbox August 6, 2020 11:27
@mergify mergify bot merged commit 8065503 into tinkerbell:master Aug 6, 2020
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants