Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix binary permission during ci #244

Merged
merged 1 commit into from
Aug 7, 2020
Merged

fix binary permission during ci #244

merged 1 commit into from
Aug 7, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Aug 7, 2020

We have to set binary permission otherwise this information gets lost
when moving from the go build job to docker image build in GitHub CI.

https://github.com/actions/download-artifact#permission-loss

We have to set binary permission otherwise this information gets lost
when moving from the go build job to docker image build in GitHub CI.

https://github.com/actions/download-artifact#permission-loss
Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
Copy link
Contributor

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change ensures execution bit is set.

/lgtm

@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Aug 7, 2020
@gianarb gianarb merged commit 8fa5164 into tinkerbell:master Aug 7, 2020
@gianarb gianarb deleted the hotfix/binary-permision-ci branch August 7, 2020 13:22
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants