Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Terraform provisioning #103 #254

Merged

Conversation

Cbkhare
Copy link
Contributor

@Cbkhare Cbkhare commented Aug 17, 2020

Description

PR enables the terraform setup creation and installation of dependent packages like docker and docker-compose.
This script is written in such a way where it can be extended to add the other dependent packages.

Why is this needed

tinkerbell/tinkerbell.org#103

Fixes: #

  • Added a script to install dependent packages.

How Has This Been Tested?

Testing has been completed by creating tink-provisioner using terraform for OS centos_8 and ubuntu_18_04. Below are the test results.

  • Ubunut result
root@tink-provisioner-cb:~# lsb_release -a 
No LSB modules are available.
Distributor ID:	Ubuntu
Description:	Ubuntu 18.04.5 LTS
Release:	18.04
Codename:	bionic
root@tink-provisioner-cb:~# docker --version 
Docker version 19.03.6, build 369ce74a3c
root@tink-provisioner-cb:~# docker-compose --version 
docker-compose version 1.17.1, build unknown
  • Centos result
[root@tink-provisioner-cb ~]# lsb_release -a 
LSB Version:	:core-4.1-amd64:core-4.1-noarch
Distributor ID:	CentOS
Description:	CentOS Linux release 8.1.1911 (Core) 
Release:	8.1.1911
Codename:	Core
[root@tink-provisioner-cb ~]# docker --version 
Docker version 19.03.12, build 48a66213fe
[root@tink-provisioner-cb ~]# docker-compose --version 
docker-compose version 1.26.2, build unknown

Documentation required

  • Status of execution of the script can be checked from location /var/log/cloud-init-output.log

@Cbkhare Cbkhare force-pushed the Fix_for_terraform_provisioning_#103 branch from 1027103 to 1aebf3e Compare August 17, 2020 14:22
@Cbkhare Cbkhare requested a review from gianarb August 17, 2020 14:23
@Cbkhare Cbkhare force-pushed the Fix_for_terraform_provisioning_#103 branch 4 times, most recently from 20c1491 to 5b5d27f Compare August 19, 2020 08:36
@Cbkhare Cbkhare marked this pull request as ready for review August 19, 2020 09:50
@Cbkhare Cbkhare requested a review from displague August 19, 2020 09:55
@Cbkhare Cbkhare force-pushed the Fix_for_terraform_provisioning_#103 branch from 56327a0 to 7272445 Compare August 19, 2020 09:57
@gianarb
Copy link
Contributor

gianarb commented Aug 19, 2020

@Cbkhare can you revert this commit ee46b71 back from your branch and rebase to master?!

Thanks

Signed-off-by: cbkhare <Chitrabasukhare89@gmail.com>

Fix for Terraform provisioning tinkerbell#103

Fix for Terraform provisioning tinkerbell#103

Fix for Terraform provisioning tinkerbell#103

Signed-off-by: cbkhare <Chitrabasukhare89@gmail.com>

Fix for Terraform provisioning tinkerbell#103

Signed-off-by: cbkhare <Chitrabasukhare89@gmail.com>

Fix for Terraform provisioning tinkerbell#103

Removal of Packet references

This removes the `_packet` from the health end point and renames it to the standard `healthz`. It also renames environment variables to TINKERBELL inline with the project

Signed-off-by: thebsdbox <dan@thebsdbox.co.uk>

Revert of env variables

Signed-off-by: thebsdbox <dan@thebsdbox.co.uk>
@Cbkhare Cbkhare force-pushed the Fix_for_terraform_provisioning_#103 branch from ee46b71 to 9db66c1 Compare August 19, 2020 13:31
@gianarb gianarb added kind/bug Categorizes issue or PR as related to a bug. ready-to-merge Signal to Mergify to merge the PR. labels Aug 19, 2020
Copy link
Contributor

@gianarb gianarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of it!

@Cbkhare Cbkhare merged commit ce313da into tinkerbell:master Aug 19, 2020
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants