Removal of Packet references #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebsdbox
force-pushed
the
remove_packet
branch
from
49b12ce
to
6330552
Compare
thebsdbox
added
priority/backlog
This removes the `_packet` from the health end point and renames it to the standard `healthz`. It also renames environment variables to TINKERBELL inline with the project Signed-off-by: thebsdbox <dan@thebsdbox.co.uk>
Signed-off-by: thebsdbox <dan@thebsdbox.co.uk>
thebsdbox
force-pushed
the
remove_packet
branch
from
36d7cc7
to
312753a
Compare
gianarb
approved these changes
Aug 18, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the
_packetfrom the health end point and renames it to the standardhealthz. It also renames environment variables toTINKERBELLinline with the projectWhy is this needed
This decouples the project from Packet.
Fixes: #227
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: