Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecov as part of ci checks #261

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Add codecov as part of ci checks #261

merged 1 commit into from
Aug 19, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Aug 19, 2020

Osie uses codecov already, this PR extends its use with the tink
repository.

Right now there is not support for PR comments or things like that. It
just updates codecov

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@ace7f59). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #261   +/-   ##
=========================================
  Coverage          ?   10.90%           
=========================================
  Files             ?        7           
  Lines             ?     1165           
  Branches          ?        0           
=========================================
  Hits              ?      127           
  Misses            ?     1019           
  Partials          ?       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ace7f59...75ecb74. Read the comment docs.

@gianarb gianarb requested a review from displague August 19, 2020 13:44
@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Aug 19, 2020
displague
displague previously approved these changes Aug 19, 2020
Copy link
Member

@displague displague left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume merging to master will fix the warning codecov is reporting.

https://docs.codecov.io/docs/error-reference#section-missing-base-commit

@gianarb
Copy link
Contributor Author

gianarb commented Aug 19, 2020

Yes @displague

Osie uses codecov already, this PR extends its use with the tink
repository.

Right now there is not support for PR comments or things like that. It
just updates codecov

Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
@gianarb gianarb requested a review from displague August 19, 2020 14:01
@gauravgahlot gauravgahlot self-requested a review August 19, 2020 14:19
Copy link
Contributor

@gauravgahlot gauravgahlot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much awaited.

@gianarb gianarb merged commit 432bd42 into tinkerbell:master Aug 19, 2020
@gianarb gianarb deleted the chore/add-codecov branch August 19, 2020 14:20
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants