Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase go test timeout for vagrant tests #262

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Increase go test timeout for vagrant tests #262

merged 1 commit into from
Aug 20, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Aug 19, 2020

Right now there is only one test that runs as part of the vagrant
test suite the default go test timeout (10s) is enough.

It won't stay for long.

@gianarb gianarb requested a review from parauliya August 19, 2020 14:42
Right now there is only one tests that runs as part of the vagrant
test suite the default go test timeout (10s) is enough.

It won't stay for long.

Signed-off-by: Gianluca Arbezzano <gianarb92@gmail.com>
@gianarb gianarb added area/ci-cd-release ready-to-merge Signal to Mergify to merge the PR. labels Aug 19, 2020
@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #262 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #262   +/-   ##
=======================================
  Coverage   12.36%   12.36%           
=======================================
  Files           7        7           
  Lines        1165     1165           
=======================================
  Hits          144      144           
  Misses       1010     1010           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8884a...2038ead. Read the comment docs.

Copy link
Contributor

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is approved.

@gianarb gianarb removed the request for review from parauliya August 20, 2020 07:52
@gianarb gianarb merged commit adb49da into tinkerbell:master Aug 20, 2020
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants