Reading hardware data from stdin

[gauravgahlot]

At present, the hardware data is pushed as shown below and is not the right (or best) way to do it:

$ tink hardware push 'hadware-data-json'

With the code changes in place, a user can now pipe the hardware data from a JSON file. For example, if the data is saved in /tmp/data.json, you can push the data with either of the following:

$ cat /tmp/data.json | tink hardware push
$ tink hardware push --file /tmp/data.json

Also, if there is no error a confirmation message saying Hardware data pushed successfully is received after the data is pushed.

Signed-off-by: Gaurav Gahlot gaurav.gahlot19@gmail.com

[mikemrm]

This looks good to me, however we need to update the documentation and examples since this is a breaking change.

[nathangoulding]

I think having the capability to read the hardware data from a file is definitely advantageous, especially for large blobs and/or a process that writes to a hardware file asynchronously.

My suggestion is that we add the stdin as you've done it, but also have a -f <file> parameter to support the existing file-based mechanism.

[nathangoulding]

See comment.

[gauravgahlot]

@nathangoulding That makes sense, I will do the changes.
@mikemrm I didn't update the docs here because I'm of the opinion that tinkerbell.org should serve as the sole documentation resource. And, so we can remove all the duplicate documentation from Tink.

Please let me know your thoughts on this.

will update the docs as part of a different PR

[alexellis]

This looks great guys. Nice work on it. 👍