Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added terraform into deploy dir #96

Merged
merged 3 commits into from
May 6, 2020
Merged

Conversation

kqdeng
Copy link
Contributor

@kqdeng kqdeng commented May 5, 2020

  • Ported the terraform scripts from the demo-v2 branch
  • Specified in input.tf to use user api key
  • moved setup.sh into deploy directory

Copy link
Contributor

@gauravgahlot gauravgahlot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdeng3849 Since you are moving setup.sh to /deploy you will need to change a few things in the script and update the docs as well.

@parauliya
Copy link
Contributor

parauliya commented May 6, 2020

  • Ported the terraform scripts from the demo-v2 branch
  • Specified in input.tf to use user api key
  • moved setup.sh into deploy directory

I think instead of moving setup.sh into deploy dir you can directly copy that file to the provisioner machine through terraform script at a certain place and then you can login to provisioner and run that script.

Copy link
Contributor

@parauliya parauliya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think instead of moving setup.sh into deploy dir you can directly copy that file to the provisioner machine through terraform script at a certain place and then you can login to provisioner and run that script.

@kqdeng
Copy link
Contributor Author

kqdeng commented May 6, 2020

@parauliya I actually think it's better to keep it separate. I remember there were sometimes problems with terraform not being able to ssh into the provisioner and then it just stops the entire operation.
I also think it's better to align the steps for both setup with terraform and manual setup because it would get confusing if there's going to be "if you created the servers with terraform run the script here, otherwise the script is over there", etc.

@parauliya
Copy link
Contributor

@parauliya I actually think it's better to keep it separate. I remember there were sometimes problems with terraform not being able to ssh into the provisioner and then it just stops the entire operation.
I also think it's better to align the steps for both setup with terraform and manual setup because it would get confusing if there's going to be "if you created the servers with terraform run the script here, otherwise the script is over there", etc.

I agree with you on that but still I do not see a reason for moving the setup.sh into deploy folder else you have to do few changes in the setup.sh as well as @gauravgahlot mentioned in his comment.

@kqdeng
Copy link
Contributor Author

kqdeng commented May 6, 2020

I agree with you on that but still I do not see a reason for moving the setup.sh into deploy folder else you have to do few changes in the setup.sh as well as @gauravgahlot mentioned in his comment.

The thought was to keep all things setup together and also to have the generated envrc file in the same directory as the docker-compose.yml for more convenient access after logging back into the provisioner machine. (I found myself having to do source ../envrc quite often and it does get a bit cumbersome after a few times)

@kqdeng
Copy link
Contributor Author

kqdeng commented May 6, 2020

@parauliya @gauravgahlot I will first move setup.sh back to outside deploy and then create a separate pr for that so as to not block the terraform scripts getting merged.

@kqdeng kqdeng changed the title added terraform and moved everything setup into the deploy dir added terraform into deploy dir May 6, 2020
@gauravgahlot gauravgahlot merged commit 87c2d85 into tinkerbell:master May 6, 2020
mmlb pushed a commit to mmlb/tinkerbell-tink that referenced this pull request May 21, 2020
* added terraform and moved everything setup into the deploy dir

* moved back setup.sh

* changed default worker plan
parauliya pushed a commit to infracloudio/tink that referenced this pull request May 22, 2020
* added terraform and moved everything setup into the deploy dir

* moved back setup.sh

* changed default worker plan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants