Skip to content

NEW: reset global seed before every test case #155

Merged
merged 4 commits into from
Oct 11, 2021
Merged

Conversation

martins0n
Copy link
Contributor

@martins0n martins0n commented Oct 7, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

The order of test cases is every important in the case of using random.
As the first step of fixing randomness of random - reset of global state for every test case is proposed

Related Issue

Closing issues

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2021

Codecov Report

Merging #155 (97b9eec) into master (ffbc70e) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   87.18%   87.15%   -0.04%     
==========================================
  Files          71       71              
  Lines        3106     3106              
==========================================
- Hits         2708     2707       -1     
- Misses        398      399       +1     
Impacted Files Coverage Δ
etna/datasets/tsdataset.py 86.43% <33.33%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffbc70e...97b9eec. Read the comment docs.

@martins0n martins0n merged commit 50f2074 into master Oct 11, 2021
@martins0n martins0n deleted the bug/random_seed branch October 11, 2021 08:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants