Skip to content

Add regressors property to TSDataset #82

Merged
merged 10 commits into from Oct 4, 2021
Merged

Add regressors property to TSDataset #82

merged 10 commits into from Oct 4, 2021

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Sep 22, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (checklist)

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contribution guide?
  • Did you check the code style? make lint (poetry install -E style).
  • Did you make sure to update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you check that your code passes the unit tests pytest tests/ ?
  • Did you add your new functionality to the docs?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Add regressors property to TSDataset which returns dict where keys are segments and values are regressor columns for these segments.

Rewrite make_future to use this new property.

Related Issue

#75.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Closing issues

Closes #75.

@Mr-Geekman Mr-Geekman added the enhancement New feature or request label Sep 22, 2021
@Mr-Geekman Mr-Geekman self-assigned this Sep 22, 2021
@Mr-Geekman Mr-Geekman changed the title Add regressor property to TSDataset Add regressors property to TSDataset Sep 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #82 (52fb8e5) into master (9d4f55f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   88.03%   88.08%   +0.04%     
==========================================
  Files          55       55              
  Lines        2541     2551      +10     
==========================================
+ Hits         2237     2247      +10     
  Misses        304      304              
Impacted Files Coverage Δ
etna/datasets/tsdataset.py 87.43% <100.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d4f55f...52fb8e5. Read the comment docs.

@Mr-Geekman Mr-Geekman marked this pull request as ready for review September 28, 2021 07:22
Copy link
Contributor

@julia-shenshina julia-shenshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@julia-shenshina julia-shenshina merged commit d87744b into master Oct 4, 2021
@iKintosh iKintosh deleted the issue-75 branch October 15, 2021 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add regressor property to TSDataset
3 participants