Skip to content

Update _update_regressors logic with new transforms behavior #328

Closed
1 task done
julia-shenshina opened this issue Nov 29, 2021 · 1 comment · Fixed by #374
Closed
1 task done

Update _update_regressors logic with new transforms behavior #328

julia-shenshina opened this issue Nov 29, 2021 · 1 comment · Fixed by #374
Assignees
Labels
enhancement New feature or request

Comments

@julia-shenshina
Copy link
Contributor

julia-shenshina commented Nov 29, 2021

🚀 Feature Request

In #326 we are going to add some knowledge about ability to convert data to regressors to transforms. In this issue we are need to update TSDataset.transform method according new rules.

Motivation

New way of work with regressors.

Proposal

  • delete _update_regressors method
  • in transform loop for each transform check:
    • if it is instance of FutureMixin or it's in_column is in self._regressors, add its output_column to self._regressors
    • do nothing otherwise

Note that once added to self._regressors column cannot be moved out there.

Test cases

Update existing cases with new logic

Alternatives

No response

Additional context

is blocked by #389 #385

Checklist

  • I discussed this issue with ETNA Team
@julia-shenshina julia-shenshina added the enhancement New feature or request label Nov 29, 2021
@julia-shenshina
Copy link
Contributor Author

is blocked by #326

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants