Regularization search #1001
Merged
Regularization search #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-1001--etna-docs.netlify.app |
Codecov Report
@@ Coverage Diff @@
## master #1001 +/- ##
==========================================
+ Coverage 85.73% 85.79% +0.05%
==========================================
Files 160 162 +2
Lines 8548 8603 +55
==========================================
+ Hits 7329 7381 +52
- Misses 1219 1222 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Mr-Geekman
reviewed
Nov 2, 2022
CHANGELOG.md
Outdated
| @@ -14,7 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| - Add `plot_change_points_interactive` ([#988](https://github.com/tinkoff-ai/etna/pull/988)) | |||
| - Add `experimental` module with `TimeSeriesBinaryClassifier` and `PredictabilityAnalyzer` ([#985](https://github.com/tinkoff-ai/etna/pull/985)) | |||
| - Inference track results: add `predict` method to pipelines, teach some models to work with context, change hierarchy of base models, update notebook examples ([#979](https://github.com/tinkoff-ai/etna/pull/979)) | |||
| - | |||
| - Add `get_ruptures_regularization` in `experimental` module ([#1001](https://github.com/tinkoff-ai/etna/pull/1001)) | |||
Mr-Geekman
reviewed
Nov 2, 2022
Mr-Geekman
reviewed
Nov 2, 2022
Mr-Geekman
reviewed
Nov 2, 2022
Mr-Geekman
reviewed
Nov 2, 2022
Mr-Geekman
reviewed
Nov 2, 2022
| Returns | ||
| ------- | ||
| : | ||
| regularization parameters values |
There was a problem hiding this comment.
May be we should somehow explain how this format is working.
Mr-Geekman
suggested changes
Nov 2, 2022
Mr-Geekman
reviewed
Nov 2, 2022
Mr-Geekman
reviewed
Nov 2, 2022
| : | ||
| regularization parameters value | ||
|
|
||
| Raises |
There was a problem hiding this comment.
Aren't there should be two errors?
There was a problem hiding this comment.
Is the new version better?
There was a problem hiding this comment.
Let's separate it into two errors.
And I think that we should change "so" -> "too":
"is too low for needed n_bkps"
Mr-Geekman
approved these changes
Nov 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Closing issues