Skip to content

Fix/other stacked notebooks #1034

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Conversation

martins0n
Copy link
Contributor

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

@github-actions github-actions bot temporarily deployed to pull request December 8, 2022 09:15 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2022

Codecov Report

Merging #1034 (5d9118d) into master (b8e45f8) will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
+ Coverage   85.99%   86.16%   +0.16%     
==========================================
  Files         162      163       +1     
  Lines        8628     8629       +1     
==========================================
+ Hits         7420     7435      +15     
+ Misses       1208     1194      -14     
Impacted Files Coverage Δ
etna/__init__.py 100.00% <0.00%> (ø)
etna/transforms/nn/pytorch_forecasting.py 95.23% <0.00%> (+4.76%) ⬆️
etna/models/tbats.py 95.00% <0.00%> (+10.00%) ⬆️
etna/auto/utils.py 94.73% <0.00%> (+21.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot temporarily deployed to pull request December 15, 2022 12:47 Inactive
Copy link
Collaborator

@alex-hse-repository alex-hse-repository left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you ran the tests for notebooks and check that everything is all right now?

@@ -0,0 +1,32 @@
import json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where it is planned to use this script?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of corrupted cache as it was today on master branch -- you can delete cache manually via this script

@martins0n
Copy link
Contributor Author

Did you ran the tests for notebooks and check that everything is all right now?

https://github.com/tinkoff-ai/etna/actions/runs/3702532515/jobs/6276086714

@alex-hse-repository alex-hse-repository merged commit 5ff32b2 into master Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants