Fix bug with hardcoded frequency in PytorchForecastingTransform
#107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d notes about position sensitivity of transform, write tests
Mr-Geekman
added
bug
Mr-Geekman
changed the title
PytorchForecastingTransformerPytorchForecastingTransform
added 4 commits
September 28, 2021 14:09
# Conflicts: # CHANGELOG.md
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 87.77% 87.79% +0.02%
==========================================
Files 54 54
Lines 2478 2483 +5
==========================================
+ Hits 2175 2180 +5
Misses 303 303
Continue to review full report at Codecov.
|
martins0n
suggested changes
Sep 28, 2021
| Notes | ||
| ----- | ||
| This transform should be added at the very end of `transforms` parameter. | ||
|
|
There was a problem hiding this comment.
Maybe we should raise Exception?
added 2 commits
September 28, 2021 17:13
iKintosh
pushed a commit
that referenced
this pull request
Oct 7, 2021
* Fix bug with hardcoded frequency in PytorchForecastingTransformer, add notes about position sensitivity of transform, write tests (cherry picked from commit 262fa68)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Before submitting (must do checklist)
Type of Change
Proposed Changes
Related Issue
#106.
Closing issues
Closes #106.