Skip to content

BUG Gale-Shapley #1110

Merged
merged 4 commits into from Feb 14, 2023
Merged

BUG Gale-Shapley #1110

merged 4 commits into from Feb 14, 2023

Conversation

Ama16
Copy link
Contributor

@Ama16 Ama16 commented Feb 13, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

Closes #1097

@github-actions
Copy link

github-actions bot commented Feb 13, 2023

@github-actions github-actions bot temporarily deployed to pull request February 13, 2023 15:34 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 13, 2023 15:40 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Merging #1110 (72a1a51) into master (da08758) will decrease coverage by 18.41%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           master    #1110       +/-   ##
===========================================
- Coverage   86.86%   68.45%   -18.41%     
===========================================
  Files         170      170               
  Lines        9324     9321        -3     
===========================================
- Hits         8099     6381     -1718     
- Misses       1225     2940     +1715     
Impacted Files Coverage Δ
etna/transforms/feature_selection/gale_shapley.py 100.00% <100.00%> (ø)
etna/commands/__main__.py 0.00% <0.00%> (-87.50%) ⬇️
etna/datasets/hierarchical_structure.py 22.01% <0.00%> (-75.23%) ⬇️
etna/libs/pmdarima_utils/arima.py 28.84% <0.00%> (-71.16%) ⬇️
etna/pipeline/assembling_pipelines.py 26.31% <0.00%> (-71.06%) ⬇️
etna/pipeline/mixins.py 31.42% <0.00%> (-67.62%) ⬇️
etna/analysis/outliers/hist_outliers.py 10.82% <0.00%> (-66.25%) ⬇️
etna/reconciliation/bottom_up.py 35.29% <0.00%> (-64.71%) ⬇️
etna/auto/optuna/config_sampler.py 32.25% <0.00%> (-62.91%) ⬇️
etna/models/deadline_ma.py 35.18% <0.00%> (-59.26%) ⬇️
... and 60 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -19,6 +19,32 @@
from tests.test_transforms.utils import assert_transformation_equals_loaded_original


@pytest.fixture
def get_ts_with_exog_galeshapley(random_seed) -> TSDataset:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should name it without get, because we don't use it as a function.

@github-actions github-actions bot temporarily deployed to pull request February 14, 2023 09:13 Inactive
@Ama16 Ama16 merged commit 7b58e3c into master Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] GaleShapleyFeatureSelectionTransform doesn't keep 2 features with top_k=2
3 participants