Skip to content

Add params_to_tune for linear models #1204

Merged
merged 2 commits into from Apr 6, 2023
Merged

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Apr 5, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Look at #1192.

Closing issues

Closes #1192.

@Mr-Geekman Mr-Geekman self-assigned this Apr 5, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

@github-actions github-actions bot temporarily deployed to pull request April 5, 2023 08:40 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (automl-2.0@e919876). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff              @@
##             automl-2.0    #1204   +/-   ##
=============================================
  Coverage              ?   69.04%           
=============================================
  Files                 ?      177           
  Lines                 ?    10490           
  Branches              ?        0           
=============================================
  Hits                  ?     7243           
  Misses                ?     3247           
  Partials              ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -117,6 +147,16 @@ def __init__(self, alpha: float = 1.0, l1_ratio: float = 0.5, fit_intercept: boo
)
)

def params_to_tune(self) -> Dict[str, "BaseDistribution"]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about linear per-segment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is added higher.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought you added it to adapter)

etna/models/linear.py Show resolved Hide resolved
@alex-hse-repository alex-hse-repository merged commit 2ae199b into automl-2.0 Apr 6, 2023
12 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants