Skip to content

Fix warning during creation of ResampleWithDistributionTransform #1230

Merged
merged 3 commits into from Apr 19, 2023

Conversation

Mr-Geekman
Copy link
Contributor

@Mr-Geekman Mr-Geekman commented Apr 18, 2023

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Move creation of out_column

Closing issues

Closes #1006.

@github-actions
Copy link

github-actions bot commented Apr 18, 2023

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Merging #1230 (a6a1737) into master (6eee08e) will decrease coverage by 30.21%.
The diff coverage is 71.42%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           master    #1230       +/-   ##
===========================================
- Coverage   87.69%   57.49%   -30.21%     
===========================================
  Files         186      186               
  Lines       10621    10617        -4     
===========================================
- Hits         9314     6104     -3210     
- Misses       1307     4513     +3206     
Impacted Files Coverage Δ
etna/transforms/missing_values/resample.py 50.00% <71.42%> (-47.15%) ⬇️

... and 114 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot temporarily deployed to pull request April 18, 2023 11:21 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 18, 2023 14:04 Inactive
@alex-hse-repository alex-hse-repository merged commit 3cd565b into master Apr 19, 2023
13 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Warning during creation of ResampleWithDistributionTransform
3 participants